conjure icon indicating copy to clipboard operation
conjure copied to clipboard

Allow dashes and underscores in arg parameter names

Open brikeohane opened this issue 6 years ago • 2 comments

Motivation

I'd like to mock an external API found here: https://docs.microsoft.com/en-us/azure/cognitive-services/Translator/reference/v3-0-translate. It would be helpful to define all objects and jersey Service API's within conjure since there is no external SDK available for this service. Then, I could just instantiate the service using JaxRSClient and point it to the correct URI (https://api.cognitive.microsofttranslator.com). This is blocked because the service API contains query parameters that are not within the allowed conjure formatting. In this case, api-version contains a dash, which does not match the following regex: ^[a-z]([A-Z]{1,2}[a-z0-9]|[a-z0-9])*[A-Z]?$.

Proposal

Potentially modify this to allow a wider range of parameter names. Is there a reason that we do not allow dashes or underscores in parameter names?

brikeohane avatar Oct 29 '19 22:10 brikeohane

Did you consider making a standard jax-rs or retrofit API for this service?

uschi2000 avatar Oct 30 '19 00:10 uschi2000

@uschi2000 Yes, that is the alternative approach that I am taking. Barely any more lift than using Conjure, so this isn't blocking; more just curiosity

brikeohane avatar Oct 30 '19 01:10 brikeohane