conjure-rust icon indicating copy to clipboard operation
conjure-rust copied to clipboard

Begin implementing OpenAPI -> Rust codegen

Open jgrazian opened this issue 1 year ago • 4 comments

Before this PR

After this PR

==COMMIT_MSG== ==COMMIT_MSG==

Possible downsides?

jgrazian avatar Nov 22 '24 15:11 jgrazian

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • [x] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Begin implementing OpenAPI -> Rust codegen

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Nov 22 '24 15:11 changelog-app[bot]

This seems like a reasonable thing to build but I don't think it should be done in this repo in particular.

sfackler avatar Nov 25 '24 14:11 sfackler

@sfackler Thanks for the comment, this is fine. I was having trouble trying to figure out how these changes would play nice with the RFC-002 anyway.

Are you open to the changes exposing the conjure-codegen types and generate_files_inner so that this can be moved externally?

jgrazian avatar Nov 25 '24 14:11 jgrazian

I definitely don't want to make conjure-codegen internals public API.

sfackler avatar Nov 25 '24 14:11 sfackler

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

stale[bot] avatar Jun 27 '25 04:06 stale[bot]