conjure-java icon indicating copy to clipboard operation
conjure-java copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Distinguish error logging between thrown Errors and ServiceExceptions

Open ash211 opened this issue 2 years ago • 2 comments

Before this PR

When seeing "Error handling request" in logs, it is difficult to distinguish if the problem is a thrown Error or a thrown ServiceException.

After this PR

==COMMIT_MSG== Distinguish error logging between thrown Errors and ServiceExceptions ==COMMIT_MSG==

In general, log messages from a class should be unique, so that someone seeing the message and comparing with source code can uniquely identify the location of the log.

ash211 avatar Feb 10 '23 06:02 ash211

Generate changelog in changelog/@unreleased

Type

  • [ ] Feature
  • [x] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Distinguish error logging between thrown Errors and ServiceExceptions

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Feb 10 '23 06:02 changelog-app[bot]

I frequently search for Error handling request when I want to find exceptions being thrown by my service. When starting my investigation, I don't actual know what kind of exceptions are being thrown. If different exceptions produce different error messages, it is going to be much more difficult to search for and find these errors.

Can you explain what problem you are trying to solve here? You can always determine the exception thrown by looking at the included stacktrace.

pkoenig10 avatar Feb 27 '23 21:02 pkoenig10