conjure-java icon indicating copy to clipboard operation
conjure-java copied to clipboard

Generator Should Read ExternalImportType Safety

Open lsingh123 opened this issue 2 years ago • 2 comments

If an Alias, Field, or Argument is an external import type, use the underlying import's safety instead of the declared safety (which will be empty). Converts all usages of AliasDefinition.getSafety(), FieldDefinition.getSafety(), and ArgumentDefinition.getSafety() to the corresponding wrapper methods in SafetyUtils.java.

lsingh123 avatar Feb 01 '23 23:02 lsingh123

https://github.com/palantir/conjure-java/pull/1945 is a better solution

lsingh123 avatar Feb 02 '23 21:02 lsingh123

Generate changelog in changelog/@unreleased

Type

  • [x] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Adds support for log safety annotations to external import types. For example, an alias of an external reference type will now have safety annotations on the class, getters, and setters.

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Feb 13 '23 19:02 changelog-app[bot]