bulldozer icon indicating copy to clipboard operation
bulldozer copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Remove delete_after_merge option

Open asvoboda opened this issue 4 years ago • 4 comments

GH now supports automatically deleting branches (as of 2.22.4), so Bulldozer no longer needs to support the delete_after_merge option.

We can probably remove the supporting code and leave the option around, if we don't want to break any config changes: https://github.com/palantir/bulldozer/blob/a49528932f30a3d1666ccc35c2bd28f3959422b4/bulldozer/merge.go#L215-L216

asvoboda avatar Nov 19 '20 16:11 asvoboda

Hi @asvoboda, I would like to work upon this issue if there's no one assigned to this one

anishagg17 avatar Apr 22 '21 20:04 anishagg17

Sure thing. Feel free to submit a PR and we can review.

asvoboda avatar Apr 23 '21 08:04 asvoboda

Can I please object to this? Github Enterprise doesn't support this yet, and this is a nice feature for those of us stuck on GHE.

xero-timothy avatar May 19 '21 00:05 xero-timothy

Hey @xero-timothy,

Your concern is one of the reasons we haven't yet merged this change. GHE_ does_ support the delete-after-merge option natively as of 2.21.0. However, based on our internal testing the feature was broken in 2.21.3 and not fixed until 2.22.4.

As it stands, it probably doesn't hurt to keep this redundant feature around.

asvoboda avatar May 19 '21 08:05 asvoboda