bulldozer icon indicating copy to clipboard operation
bulldozer copied to clipboard

follow doc for github default title strategy

Open clakech opened this issue 5 years ago • 3 comments

clakech avatar Jul 29 '19 11:07 clakech

Thanks for your interest in palantir/bulldozer, @clakech! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Jul 29 '19 11:07 palantirtech

Thanks for catching this, @clakech. Since changing the configuration value is technically a breaking change, I'd prefer to update the documentation to match what the code does rather than the other way around.

bluekeyes avatar Jul 29 '19 23:07 bluekeyes

Thanks for catching this, @clakech. Since changing the configuration value is technically a breaking change, I'd prefer to update the documentation to match what the code does rather than the other way around.

I think it is better this way.

If you update the doc according to the doc then your title strategies names will be inconsistent ;)

  • pull_request_title
  • first_commit_title
  • github_default

clakech avatar Jul 30 '19 07:07 clakech