blueprint icon indicating copy to clipboard operation
blueprint copied to clipboard

Fix button group stacking context

Open evansjohnson opened this issue 7 months ago • 4 comments

Fixes https://github.com/palantir/blueprint/issues/7440

Checklist

  • [n/a] Includes tests
  • [n/a] Update documentation

Changes proposed in this pull request:

Reset stacking context of button group component

Reviewers should focus on:

Could this unintentionally override any consumer land styling?

Screenshot

Screenshot 2025-04-15 at 11 37 47 PM Screenshot 2025-04-15 at 11 37 41 PM

This PR ended up using the translateZ(0) method to reset the stacking context like we do for control groups but anything that resets the stacking context should be valid.

evansjohnson avatar Apr 16 '25 03:04 evansjohnson

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • [ ] Feature
  • [ ] Improvement
  • [x] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Fix button group stacking context

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Apr 16 '25 03:04 changelog-app[bot]

apply same fix as control group

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github avatar Apr 16 '25 03:04 svc-palantir-github

Screenshot 2025-04-15 at 11 44 31 PM

an LLM response when asking I need to reset a z-index stacking context in CSS, are there any performance considerations between z-index: 0 and transform: translateZ(0)? which would be more performant?

seeing this I'm tempted to say we should at least avoid introducing more translateZ(0), specifically for button groups which there may be a lot of rendered at once

we could separately consider switching the implementation to reset the control group stacking context but that has been in place for awhile

evansjohnson avatar Apr 16 '25 03:04 evansjohnson

lint?

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github avatar Apr 16 '25 04:04 svc-palantir-github