blueprint icon indicating copy to clipboard operation
blueprint copied to clipboard

MultiSelect onKeyUp props not being correctly called

Open donghee214 opened this issue 7 months ago • 0 comments

The incorrect prop is being called here when the keyUp event is called: https://github.com/palantir/blueprint/blob/dd1db7cc658f64e23510c9c035a3c18eba519679/packages/select/src/components/multi-select/multiSelect.tsx#L405

Environment

  • Package version(s): @blueprintjs/select-version": "5.2.1"
  • Operating System: MacOS Sonoma 14.5 (23F79)
  • Browser name and version: Chrome 126.0.6478.127 (arm64)

Code Sandbox

Will add briefly

Steps to reproduce

  1. Create MultiSelect Component
  2. Pass in onKeyUp Prop
  3. Navigate through the dropdown using keys

Actual behavior

onKeyDown prop is called on keyUp events

Expected behavior

onKeyDown prop is called on keyDown events

Possible solution

Replace here with onKeyUp. THIS WOULD TECHNICALLY BE A BREAKING CHANGE

donghee214 avatar Jul 18 '24 16:07 donghee214