blueprint
blueprint copied to clipboard
core fix(Menu Item): Add subMenuCaretTitle field to MenuItemProps
Checklist
- [x] Includes tests
- [x] Update documentation
Changes proposed in this pull request:
The Open Sub Menu
title is not derived from any user controlled props. This means we can't internationalize it.
A new subMenuCaretTitle
prop was added to the MenuItemsProp.
Reviewers should focus on:
Screenshot
New Docs:
Caret title in question:
Generate changelog in packages/core/changelog/@unreleased
packages/core/changelog/@unreleased
What do the change types mean?
-
feature
: A new feature of the service. -
improvement
: An incremental improvement in the functionality or operation of the service. -
fix
: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. -
break
: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). -
deprecation
: Advertises the intention to remove service functionality without any change to the operation of the service itself. -
manualTask
: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. -
migration
: A fully automatic upgrade migration task with no engineer input required.
Note: only one type should be chosen.
How are new versions calculated?
- ❗The
break
andmanual task
changelog types will result in a major release! - 🐛 The
fix
changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.
Type
- [ ] Feature
- [ ] Improvement
- [x] Fix
- [ ] Break
- [ ] Deprecation
- [ ] Manual task
- [ ] Migration
Description
Check the box to generate changelog(s)
- [x] Generate changelog entry
Add generated changelog entries
Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job.