Toaster with timeout zero is dismissed early

[dylangrandmont]

Environment

• Package version(s): "@blueprintjs/core": "^5.10.0",
• Operating System: Mac OS 14
• Browser name and version: Chrome 122

Code Sandbox

Code sandbox

Steps to reproduce

See the linked code sandbox

1. Open a Toast with timeout of 0. Note that focusing the toast will dismiss it (without clicking the 'x')
2. Note that with an explicit timeout (e.g. 100_000) this is not the case; Toast remains open after focusing.
3. timeout: Infinity is poorly behaved; Toast immediately closes

Actual behavior

See above and also screen recording from sandbox:

https://github.com/palantir/blueprint/assets/20345725/40bc7800-1b37-4cf9-bd1a-405425e835df

Expected behavior

Toast with timeout: 0 should not dismiss early. timeout: Infinity should also behave the same as timeout: 0

[gluxon]

Thanks for the bug report @dylangrandmont! Fix for 0 here https://github.com/palantir/blueprint/pull/6783. We should probably handle Infinity better as you mentioned.

[gluxon]

Will leave this open for the Infinity part of the problem.

[ericjeney]

Thanks, @gluxon! Let's also track adding a test case as part of fixing this issue.

[AustineChi]

Thanks, @gluxon! Let's also track adding a test case as part of fixing this issue.

Hi @ericjeney , I'd like to work on resolving the issue with handling timeout: Infinity. Please can you let me know if someone is working on this already?

[gluxon]

Hey @AustineChi, I hadn't started yet. Would appreciate the help.