blueprint icon indicating copy to clipboard operation
blueprint copied to clipboard

Modifying the time doesn't show up on the timepicker in DateRangePicker

Open colmex opened this issue 3 years ago • 1 comments

Environment

  • Package version(s): 4.3.4
  • Operating System: MacOS Monterey
  • Browser name and version: Firefox 103.0.2

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-gb14b7

Steps to reproduce

  1. Select two dates in the daterangepicker

Actual behavior

Modifying the endTime (from 00:00 to 23:59) doesn't show the modified end time in the time picker. (I modify the time in the onChange)

Expected behavior

When I change the time on the endDate value, it should update on the DateRangePicker end time

Possible solution

It looks like it doesn't update the startTime or endTime in the code when the props change, only on the construction. Modify it so it does do that.

colmex avatar Aug 22 '22 16:08 colmex

This looks like the same issue as https://github.com/palantir/blueprint/issues/3967, but you have a code sandbox so that's helpful. I will close the other issue in favor of this one.

adidahiya avatar Aug 22 '22 20:08 adidahiya