blueprint icon indicating copy to clipboard operation
blueprint copied to clipboard

Add `asyncControl` to `EditableText`

Open felixgabler opened this issue 2 years ago • 1 comments

Fixes #4678

Checklist

  • [ ] Includes tests
  • [ ] Update documentation

Changes proposed in this pull request:

Similarly to InputGroup, EditableText should support the asyncControl prop.

Reviewers should focus on:

Currently, I reuse AsyncControllableInput but also had to make that class support the multiline scenario. I wonder whether it is better to copy this class to a AsyncControllableTextArea and figure out another way of sharing code instead of having one class. What do you think?

After that decision is made, I will gladly write more tests if required. Any pointers here would also be welcome.

Screenshot

felixgabler avatar Sep 21 '21 17:09 felixgabler

Thanks for your interest in palantir/blueprint, @felixgabler! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Sep 21 '21 17:09 palantirtech