remove more spans

[scapetta]

General

Before this PR: We generated low value spans for Atlas Cassandra KVS, loadWithTs, and timed-runner.

After this PR:

==COMMIT_MSG== Remove spans for Atlas Cassandra KVS, loadWithTs, and timed-runner ==COMMIT_MSG==

Priority: P2

Concerns / possible downsides (what feedback would you like?): Downside is if someone uses these. That seems unlikely given the value they add to traces. I would like feedback on my code in PTExecutors specifically. I could have written it using optionals instead. That felt like the wrong way to me, but could be better.

Is documentation needed?: No

Compatibility

Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?: No breaks

Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?: No

The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.): Yes

Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?: No

Does this PR need a schema migration? No

Testing and Correctness

What, if any, assumptions are made about the current state of the world? If they change over time, how will we find out?:

What was existing testing like? What have you done to improve it?: No testing

If this PR contains complex concurrent or asynchronous code, is it correct? The onus is on the PR writer to demonstrate this.: It does not contain this type of code

If this PR involves acquiring locks or other shared resources, how do we ensure that these are always released?: It does not

Execution

How would I tell this PR works in production? (Metrics, logs, etc.): We will no longer see spans for Atlas Cassandra KVS, loadWithTs, and timed-runner.

Has the safety of all log arguments been decided correctly?: We are removing logging, so there is no log safety concern.

Will this change significantly affect our spending on metrics or logs?: It should reduce spend if anything.

How would I tell that this PR does not work in production? (monitors, etc.): We would still see the spans

If this PR does not work as expected, how do I fix that state? Would rollback be straightforward?: Rollback would work, although if the PR doesn't work, it is unlikely to break anything.

If the above plan is more complex than “recall and rollback”, please tag the support PoC here (if it is the end of the week, tag both the current and next PoC): NA

Scale

Would this PR be expected to pose a risk at scale? Think of the shopping product at our largest stack.: No

Would this PR be expected to perform a large number of database calls, and/or expensive database calls (e.g., row range scans, concurrent CAS)?: No

Would this PR ever, with time and scale, become the wrong thing to do - and if so, how would we know that we need to do something differently?: No

Development Process

Where should we start reviewing?: Anywhere is fine

If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?: It is not

Please tag any other people who should be aware of this PR: @jeremyk-91 @sverma30 @raiju

[changelog-app[bot]]

Generate changelog in changelog/@unreleased

Type

• [ ] Feature
• [x] Improvement
• [ ] Fix
• [ ] Break
• [ ] Deprecation
• [ ] Manual task
• [ ] Migration

Description remove span for Atlas Cassandra KVS, loadWithTs, and timed-runner

Check the box to generate changelog(s)

• [x] Generate changelog entry

[raiju]

👍

[scapetta]

ok @Sam-Kramer @sudiksha27 I have addressed all the comments. If everything looks good, I am happy to start working on the RC testing.

[scapetta]

@Sam-Kramer I am happy to. I didnt see anything about it in the contribution section and am not sure how to do it. -I know how to make an RC- I take that back, I dont see how to do that here and I assume I have to change some product to depend on my RC, but am unsure what product I should be doing that to.

[scapetta]

tested new version on catalog, all spans exist except the intentionally removed ones.

[sudiksha27]

👍🏼

[svc-autorelease]

Released 0.744.0