node-engine icon indicating copy to clipboard operation
node-engine copied to clipboard

Align module name and version

Open modulo11 opened this issue 9 months ago • 2 comments

Summary

The node-enginge buidpack is currently not following Go's versioning schema for breaking changes. Other buildpacks, e.g. https://github.com/paketo-buildpacks/procfile, https://github.com/paketo-buildpacks/environment-variables, https://github.com/paketo-buildpacks/sap-machine, are closely following the schema as well.

Use Cases

Checklist

  • [X] I have viewed, signed, and submitted the Contributor License Agreement.
  • [X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • [X] I have added an integration test, if necessary.
  • [X] I have reviewed the styleguide for guidance on my code quality.
  • [X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

modulo11 avatar May 06 '24 13:05 modulo11

Hello, @modulo11. I think packages that consume this package need to follow the versioning. Can you provide more context about the cons of the package having an inner versioning and not always being on the latest version?

pacostas avatar May 09 '24 08:05 pacostas

According to https://go.dev/blog/v2-go-modules:

Starting with v2, the major version must appear at the end of the module path (declared in the module statement in the go.mod file). For example, when the authors of the module github.com/googleapis/gax-go developed v2, they used the new module path github.com/googleapis/gax-go/v2. Users who wanted to use v2 had to change their package imports and module requirements to github.com/googleapis/gax-go/v2.

CC @dmikusa

modulo11 avatar May 15 '24 13:05 modulo11