native-image icon indicating copy to clipboard operation
native-image copied to clipboard

Published 20 hours ago • verified publisher icon paketo-buildpacks

Remove deprecated arguments

Open anthonydahanne opened this issue 1 year ago • 2 comments

BP_BOOT_NATIVE_IMAGE_BUILD_ARGUMENTS and BP_BOOT_NATIVE_IMAGE

They've been deprecated for 2 years now

Checklist

  • [x] I have viewed, signed, and submitted the Contributor License Agreement.
  • [x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • [x] I have added an integration test, if necessary.
  • [x] I have reviewed the styleguide for guidance on my code quality.
  • [x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

anthonydahanne avatar May 05 '23 19:05 anthonydahanne

I think this looks good.

@pivotal-david-osullivan I wanted to confirm with you on this? Major or minor change? I think technically we're supposed to use major with removals, but this has also been deprecated for 2 years. We could stick with major and just hold this until we're ready for another major release? It's not urgent to merge this.

Thoughts?

dmikusa avatar May 08 '23 02:05 dmikusa

I think that we should stick to convention and go with major, especially given it's not urgent to get it merged. So yes, once we have enough for a new major we can pull this in 👍

pivotal-david-osullivan avatar May 17 '23 14:05 pivotal-david-osullivan