go icon indicating copy to clipboard operation
go copied to clipboard

Implement Go RFC0002: Decide Which Go Dependencies Will Be Paketo-hosted

Open ryanmoran opened this issue 2 years ago • 3 comments

RFC

Summary

Remove the Paketo-hosted dependency.

The buildpack can use the dependency that is provided by Go which can be parsed from a JSON payload of thier download page with little to no modification. The precedence for this payload page existing can be found in the Go Docs for the website. The payload includes a SHA256 from Go meaning the artifact can be verified from the upstream. Here is a https://github.com/paketo-buildpacks/go-dist/pull/442 showing the buildpack using the dependencies directly from the Go upstream. Because this dependency can be consumed from a trusted source, we should stop hosting it ourselves.

ryanmoran avatar Sep 13 '22 16:09 ryanmoran

Will the stacks be updated as part of this change since there will no longer be a paketo-specific dependency? I'm mainly wondering if support for all stacks can be added at the same time.

jpena-r7 avatar Sep 13 '22 18:09 jpena-r7

@jpena-r7 That makes sense to me, since the upstream dependency is supposed to work for all linux consumers. Are you interested in multi-arch support as well? I'm not sure if we're well-positioned to enable that yet.

fg-j avatar Sep 13 '22 19:09 fg-j

Excellent!

There is interest in multi-arch support, but I suspect you would want to track that in a separate RFC. This fork is a first-pass at adding multi-arch support (and all stacks). We plan to propose changes to postal to support something like this universally.

jpena-r7 avatar Sep 13 '22 20:09 jpena-r7

@paketo-buildpacks/go-maintainers is this done?

fg-j avatar Nov 28 '22 19:11 fg-j

@fg-j yep.

ryanmoran avatar Nov 28 '22 21:11 ryanmoran