signal-backup-decode icon indicating copy to clipboard operation
signal-backup-decode copied to clipboard

Published 20 hours ago • verified publisher icon pajowu

Fixing #40: Support KeyValue

Open mutlusun opened this issue 3 years ago • 4 comments

Hello,

This PR is intended to fix #40 by adding support for the output of keyvalue frames. In addition, there are some small code cleanups. For example: I have removed checking the number of frames in frame.rs::new. I think there is no case in protobuf where a frame has two different contents and it is only necessary to check for unknown frame contents.

Best, mutlusun

mutlusun avatar Mar 26 '21 07:03 mutlusun

Dear @pajowu ,

Thanks for your feedback. Please see my reply in the inline comment.

mutlusun avatar Mar 29 '21 07:03 mutlusun

Sorry for the long wait, I added another comment to our inline discussion

pajowu avatar Apr 30 '21 11:04 pajowu

Thanks for your reply. If CI does not throw any error, it's ready to be merged from my side.

mutlusun avatar May 07 '21 06:05 mutlusun

I'm sorry that the commit history got so messy ...

mutlusun avatar May 07 '21 06:05 mutlusun