pajlads
Adds bingo notifier based on loot notifier
The bingo notifier is based off loot notifier, however only cares about the item allowlist.
OSRS bingos are typically based on obtaining items around the game. Bingo events are short-term and need items configured specifically for the event.
Loot notifier already supports this functionality. However, in the case where clans/groups already have loot notifier configured for long-term loot sharing a separate notifier is needed. With bingo notifier, clans/groups can maintain their existing loot notifier and easily configure a short term discord channel/dink configuration for the event.
Example: I've actually just run into this myself and wanted a solution for it. I'm running a clan bingo with only 25 of our 75 members where I've written a custom discord bot to auto-update the bingo board. A majority of the members already have loot notifier setup. Rather than filtering the existing loot notifications for those in the bingo & not, it is much easer to just create a new channel and have members point this separate notifier to the temporary channel.
Hi @pajlada @iProdigy,
I'm not sure what the process is for contributing to the repo. Let me know if I need to open an issue first or anything else!
This is a fine approach, no issue needed. We can hold any discussion here. I'm currently limited on time until late next week so it'll be a little bit until I can commit to a proper review timeline.
With bingo notifier, clans/groups can maintain their existing loot notifier and easily configure a short term discord channel/dink configuration for the event.
Have you considered using another discord plugin like https://runelite.net/plugin-hub/show/discord-rare-drop-notificater to manage the separate allowlist for your bingo?
It's a bit ugly to duplicate the loot notifier within dink for this purpose - our medium-term vision is to have a system that supports different notifier configurations per-url so we only need the loot notifier code once... i'm (slowly) working on a system that accepts JSON and the long-term vision is to have a sidepanel that provides a nice UI for the per-url configs #480
I have considered other plugins (we are currently using Better Bingo, but they are not as comprehensive with loot tracking as dink is (#106).
It's a bit ugly to duplicate the loot notifier within dink for this purpose
I understand duplicating code in the same repo is not elegant and I think the proposed solution to accept json configs is great. I see this PR as a more short-term win that's already implemented and can be deprecated when the more robust solution can be supported.
but they are not as comprehensive with loot tracking as dink is (#106).
Could you please compile a list of missing loot sources you need that are missing from BossHuso's plugin? I'm willing to make PRs there to improve feature parity as a short-term solution
I haven't reviewed the code yet, but I am ok with us having a short term bingo notifier if it has a label that it might not be properly migrated once we go through the sidebar change