DinkPlugin icon indicating copy to clipboard operation
DinkPlugin copied to clipboard

fix(loot): use jagex loot tracker

Open pajlada opened this issue 9 months ago • 2 comments

works on #727

Thought I'd start working on this, and making a PR so there's an artifact to test with. I have purposefully not removed the other notification types, and have added an %EVENT_NAME% template you can add to the notification message so you can more easily compare things.

I'm mostly looking into the first 3 things of the linked issue:

  • [ ] Utilize net.runelite.client.events.ServerNpcLoot instead of net.runelite.client.events.NpcLootReceived
  • [ ] Investigate to what extent can net.runelite.client.plugins.loottracker.LootReceived be removed
  • [ ] Investigate whether any Dink-specific loot logic is obsolete

Things I've tested that work as expected:

  • Opening Coin pouches. Nothing happened before, nothing happens now
  • Killing a simple NPC (tested on Man & Goblin in Lumbridge). Both show up identically

Things I've tested that are a bit different: nvm pickpocketing won't show up in server loot events soonish https://github.com/runelite/runelite/commit/631d320550223db47decfb6d5cff0104a50a03ab

feel free to push stuff to the pr if you want to play around with things

pajlada avatar May 15 '25 22:05 pajlada

we may want to find the varbit for whether jagex's loot tracker is enabled so we can fallback to the legacy event as needed

iProdigy avatar May 16 '25 03:05 iProdigy

we may want to find the varbit for whether jagex's loot tracker is enabled so we can fallback to the legacy event as needed

this should be fixed in next weeks update

Felanbird avatar May 16 '25 04:05 Felanbird