DinkPlugin icon indicating copy to clipboard operation
DinkPlugin copied to clipboard

Drop Rarity for Collection Log and Loot

Open zeroquinc opened this issue 3 years ago • 6 comments

It would be a nice touch to see the drop rarity for the Collection Log and Loot tabs. Maybe also for Pets and Clues?

Something like this I have in mind:

GLQHA4o

Now it only shows you the GE value.

Maybe also a toggle to set Min Drop Rarity to filter out some loot drops that wouldn't get passed if under the Min Loot Value threshold.

Thoughts?

zeroquinc avatar Jan 21 '23 20:01 zeroquinc

We don't know which pet the user has received as the messaging is only "something has snuck into your pocket", so that wouldn't be possible.

Right now, drop rarity is not something we have accessible to us. I imagine this would need to be data we fetch from the wiki on a per-item basis. Since items can be received from multiple sources, we need to do a lookup on the combination of the item & where it came from. As an example of one of these, the Kraken tentacle is 1/400 from the Kraken, but 1/1,200 from a Cave kraken.

If we can add the ability to map an item + source to a drop rarity, this would be something we can add to some Loot notifications, most Clue Scrolls, & most of the Collection Log items.

pajlada avatar Jan 21 '23 20:01 pajlada

The problem I have personally with drop rates is how do we actually know it's the correct one? Unless the game secretly tells the client what drop it actually is, I see a problem with drop rates.

For example, reward casket (medium) has purple sweets listed as dropping in bunches of 5-10 & 8-12, which means pool one can be 5, 6, 7, 8, 9, 10 sweets, and pool two is 8, 9, 10, 11, 12

So how are we supposed to know what notif to fire for 8, 9, and 10 sweets, as it's a possibility from both pools. 🤔

Felanbird avatar Jan 21 '23 20:01 Felanbird

So how are we supposed to know what notif to fire for 8, 9, and 10 sweets, as it's a possibility from both pools. thinking

If an item has multiple rarities, we could just omit that information. I imagine that won't be the case for very many items since it can only apply to stackable items

pajlada avatar Jan 21 '23 20:01 pajlada

I didn't know it worked like that. I thought it already mapped the right NPC / activity. I don't really know how the other plugin does it? Maybe you could get some inspiration out of that code.

zeroquinc avatar Jan 21 '23 20:01 zeroquinc

Which plugin is this @zeroquinc ?

pajlada avatar Jan 21 '23 20:01 pajlada

Which plugin is this @zeroquinc ?

https://github.com/BossHuso/discord-rare-drop-notificater

zeroquinc avatar Jan 21 '23 21:01 zeroquinc