Pahud Hsieh

Results 356 comments of Pahud Hsieh

Yes looks like CFN only accepts single container properties https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties.html I will create an internal ticket for clarifying. Internal tracking: V1279131720

Self-assigned. We're still investigating.

Hi [EcsProperties](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-batch-jobdefinition.html#cfn-batch-jobdefinition-ecsproperties) is now available in the CFN document. We can define multiple-contianer for ECS in that prop now. It should technically work but I guess we probably need to...

>This still needs to be exposed on the L2 construct, doesn't it? Yes it would be great if we can expose that on the L2. I am making this a...

I guess this is because the default bundling base image is `sam/build-nodejs18.x ` while you are deploying to v20 lambda runtime and this might require you to specify `ARG IMAGE=`...

Thank you for the feedback. I will bring it up to the core team for further discussion.

applyRemovalPolicy only works with CfnResource try this instead: ```ts const vpces = new ec2.VpcEndpointService(this, 'Id', { vpcEndpointServiceLoadBalancers: [nlb], }); (vpces.node.tryFindChild('Id') as CfnVPCEndpointService).applyRemovalPolicy(RemovalPolicy.RETAIN); ``` Let me know if it works for...

Hi @slunk applyRemovalPolicy() is a method available in some L2 constructs, such as: BucketPolicy https://github.com/aws/aws-cdk/blob/efee07d6f17356b52b2a2e120ebe0404f554188b/packages/aws-cdk-lib/aws-s3/lib/bucket-policy.ts#L104-L111 Redshift Table https://github.com/aws/aws-cdk/blob/efee07d6f17356b52b2a2e120ebe0404f554188b/packages/%40aws-cdk/aws-redshift-alpha/lib/table.ts#L292-L294 If you look at its implementation, it essentially runs the applyRemovalPolicy() on...

This PR has a conflict that must be resolved. It has to be fixed first. As soon as CI passes with no conflicts, it would automatically bump to [pending-community-review](https://github.com/aws/aws-cdk/pulls?q=is%3Apr+is%3Aopen+label%3Apr%2Fneeds-community-review) queue...

To avoid BC, have you considered the Interface Extension with Type Guard Pattern? Keep the interface unchanged but use type guards to detect extended configs: ```typescript // Keep original interface...