Equivalent-Exchange-3 icon indicating copy to clipboard operation
Equivalent-Exchange-3 copied to clipboard

Propogate energy values across all items in an ore dictionary reference

Open jediminer543 opened this issue 9 years ago • 2 comments

Hello

Could you add the ability for the energy value calculations to propogate any changes accros all oredictionary references that don't have a defined value (or have some illogical one). This causes problems with furnaces outputting an ingot that has no EMC value. For example, in my set up currently:

Mod EMC
Forestry No EMC
Galacticraft No EMC
Industrial Craft 0.009
Project Red No EMC
Railcraft No EMC
Tinkers Construct No EMC
Thermal Foundation 192

As most ingots lack an EMC value, this then means upstream recipes will sometimes lose their EMC values.

On: 0.3.0.521

jediminer543 avatar May 24 '16 17:05 jediminer543

I'm not clear what you are experiencing here. The algorithm works like this

https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/exchange/EnergyValueRegistry.java#L61-L98

pahimar avatar May 28 '16 01:05 pahimar

If I've understood correctly, what OP wants is for direct mappings of OreDictionary registered items to be automatically promoted to OD mappings under certain circumstances. My suggestion would be to do a pass over the pre-calc map before you begin calculating new values and promote anything which has exactly one OD entry, unless a cheaper one is already registered.

Edit: Opened a pull request for your consideration. #1089

pterolatypus avatar Jun 29 '16 14:06 pterolatypus