Refs #87 Add support for dynamic port forwarding
This is related to issue #87 Please review my changes and if you accept them I will try to add unit and functional tests also.
IMHO it should not be accepted without tests for the new functionality.
El 29 abr. 2017 6:05 p. m., "Sorin Srn" [email protected] escribió:
This is related to issue #87 https://github.com/pahaz/sshtunnel/issues/87 Please review my changes and if you accept them I will try to add unit and functional tests also.
You can view, comment on, or merge this pull request online at:
https://github.com/pahaz/sshtunnel/pull/93 Commit Summary
- Add support for dynamic port forwarding
- Add Magic Const to a global variable
File Changes
- M sshtunnel.py https://github.com/pahaz/sshtunnel/pull/93/files#diff-0 (181)
Patch Links:
- https://github.com/pahaz/sshtunnel/pull/93.patch
- https://github.com/pahaz/sshtunnel/pull/93.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pahaz/sshtunnel/pull/93, or mute the thread https://github.com/notifications/unsubscribe-auth/AG-TbLMVqWHgogR3QHRi8yAG-br_2z-Wks5r01_DgaJpZM4NMTG9 .
What about tests? And README example?
Any news about the PR?
This looks like an excellent addition; any chance of finishing it? TIA.
As I said, please manually TEST and confirm that everything works, and afterwords I'll add tests / README example and I'll create a new pull request.
https:// github.com /paramiko/paramiko/blob/5cd4a085a11940436111b6b6f93aa369c9fb2a92/demos/demo_socks_proxy.py