io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IOPAE-1100,IOPAE-1282,IOPAE-1285] Remove old implementation of services

Open adelloste opened this issue 1 year ago • 3 comments

Short description

This PR removes the old implementation of services

List of changes proposed in this pull request

  • Removed unused services related files
  • Added migration to remove the persistence of service data in entities
  • Removed unused translation keys
  • Removed DSGradientScroll component
  • Removed TabNavigation component

How to test

Navigate through the app and check that everything is working properly

adelloste avatar Jun 25 '24 10:06 adelloste

Warnings
:warning:

Multiple stories with different types are associated with this Pull request. Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOPAE-1100: [APP] Eliminare il codice legacy della sezione servizi subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)
  • ⚙️ IOPAE-1282: [APP] Spostare store preferenze del servizio sotto features/services/details subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)
  • ⚙️ IOPAE-1285: [APP] Spostare store dettagli dei servizi sotto features/services/details subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)

Generated by :no_entry_sign: dangerJS against 6d957faf48bfa7617ad19ae8324b6a71ab5f0876

pagopa-github-bot avatar Jun 25 '24 10:06 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 87.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (4f204b4) to head (6d957fa). Report is 251 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5898      +/-   ##
==========================================
+ Coverage   48.42%   49.37%   +0.94%     
==========================================
  Files        1488     1706     +218     
  Lines       31617    33905    +2288     
  Branches     7669     8091     +422     
==========================================
+ Hits        15311    16739    +1428     
- Misses      16238    17111     +873     
+ Partials       68       55      -13     
Files Coverage Δ
ts/components/screens/BadgeComponent.tsx 66.66% <ø> (ø)
ts/components/search/SearchButton.tsx 5.40% <ø> (+0.52%) :arrow_up:
ts/config.ts 100.00% <ø> (ø)
...s/cgn/screens/merchants/CgnMerchantsTabsScreen.tsx 33.33% <ø> (-1.97%) :arrow_down:
ts/features/bonus/common/store/selectors/index.ts 92.30% <ø> (ø)
...features/design-system/core/DSLegacyPictograms.tsx 40.00% <ø> (-10.00%) :arrow_down:
ts/features/fci/hooks/useFciCheckService.tsx 43.47% <100.00%> (ø)
...eatures/fci/screens/valid/FciQtspClausesScreen.tsx 71.11% <100.00%> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 14.28% <ø> (ø)
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 8.69% <ø> (-7.98%) :arrow_down:
... and 36 more

... and 844 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 153b621...6d957fa. Read the comment docs.

codecov[bot] avatar Jun 25 '24 11:06 codecov[bot]

Apparently there are two related components that should also be deleted:

  • SectionHeaderComponent
  • services/OrganizationLogo

Also, completely off topic, there's the local TabNavigation, which has already been replaced by the new one referenced by io-app-design-system. It should be deleted as well.

If you agree, let's delete them in this PR 💪🏻

Applied suggestions

adelloste avatar Jul 04 '24 16:07 adelloste