io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOCOM-1133,IOCOM-1235,IOCOM-1372] Push Notification Opt In screen, new DS

Open Vangaorth opened this issue 10 months ago • 2 comments

⚠️ This PR depends on #5732 ⚠️ ⚠️ This PR depends on io-app-design-system#253 ⚠️ ⚠️ This PR depends on io-app-design-system#256 ⚠️

Short description

This PR aligns the Push Notifications Opt In screen and the profile push notification settings to the new DS

Both on
upper part
Both on
scrolled down
Bottom sheet
On1 Simulator Screenshot - iPhone 15 - 2024-05-10 at 12 26 26 OnBS
Preview Off
Reminder On
Preview On
Reminder Off
Both Off
Pre Rem Off
Profile
Both on
Profile
Bottom sheet
ProfileOnPreOnRem ProfileBS
Profile
On Off
Profile
Off On
Profile
Off Off
ProfileOnPreOffRem ProfileOffPreOnRem ProfileOffPreOffRem

List of changes proposed in this pull request

  • All related onboarding screens have been ported to the new DS
  • A lot of test snapshot have been updated due to a change in margins on the DS library

How to test

Using the io-dev-api-server, configure the profile in order to have both reminder_status and push_notifications_content_type set to undefined. Perform a login and the opt-in screen should appear. Check that both values are properly set after tapping the "Continue" button. For the profile screen, navigate to it and change switches' values

Vangaorth avatar May 02 '24 07:05 Vangaorth

Warnings
:warning:

Multiple stories with different types are associated with this Pull request. Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🌟 IOCOM-1133: [App] Adattare UI schermata Opt-In notifiche Push su onboarding subtask of
    • IOCOM-1132: Adottare il nuovo design system nelle schermate di primo onboarding utente su app IO
  • 🌟 IOCOM-1235: [App] Adattare UI schermata Opt-In notifiche Push su profilo subtask of
    • IOCOM-1132: Adottare il nuovo design system nelle schermate di primo onboarding utente su app IO
  • 🌟 IOCOM-1372: [App] Cambiare il componente FeatureInfo in un Banner in fondo alla schermata di OptIn subtask of
    • IOCOM-1132: Adottare il nuovo design system nelle schermate di primo onboarding utente su app IO

Generated by :no_entry_sign: dangerJS against db3a606e56e4cfbae3acba90f38e828ac06c7cdc

pagopa-github-bot avatar May 02 '24 07:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 77.01149% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 49.66%. Comparing base (4f204b4) to head (c5d33de). Report is 98 commits behind head on master.

:exclamation: Current head c5d33de differs from pull request most recent head db3a606

Please upload reports for the commit db3a606 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5734      +/-   ##
==========================================
+ Coverage   48.42%   49.66%   +1.23%     
==========================================
  Files        1488     1622     +134     
  Lines       31617    32179     +562     
  Branches     7669     7776     +107     
==========================================
+ Hits        15311    15982     +671     
+ Misses      16238    16134     -104     
+ Partials       68       63       -5     
Files Coverage Δ
img/onboarding/notification_white.png 100.00% <ø> (ø)
ts/components/ui/RNavScreenWithLargeHeader.tsx 80.76% <ø> (+3.84%) :arrow_up:
ts/config.ts 100.00% <ø> (ø)
...fications/components/NotificationPreviewSample.tsx 100.00% <100.00%> (ø)
...ons/components/NotificationsPreferencesPreview.tsx 100.00% <ø> (ø)
...ations/components/ProfileNotificationsSettings.tsx 100.00% <100.00%> (ø)
...res/pushNotifications/hooks/usePreviewMoreInfo.tsx 100.00% <100.00%> (ø)
...cations/sagas/checkNotificationsPreferencesSaga.ts 86.36% <100.00%> (ø)
ts/navigation/OnboardingNavigator.tsx 66.66% <ø> (ø)
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (+26.66%) :arrow_up:
... and 5 more

... and 524 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca2de78...db3a606. Read the comment docs.

codecov[bot] avatar May 03 '24 08:05 codecov[bot]

:tada: All dependencies have been resolved !

dpulls[bot] avatar May 22 '24 12:05 dpulls[bot]