io-app
io-app copied to clipboard
[chore] Push notification grouping
Short description
This PR groups the push-notification's related files into features/pushNotifications
.
List of changes proposed in this pull request
- All files directly related to the handling of push notifications have been moved under
features/pushNotifications
- Removed
default
exports in favour or direct ones - Profile's push notification screens have been left under the profile folders, since they are attributes of the profile and the user preferences
How to test
Run the application on the physical device and check that everything push-notification-related is working accordingly.
Warnings | |
---|---|
:warning: | Please include a Jira ticket at the beginning of the PR title |
Example of PR titles that include Jira tickets:
- single story:
[PROJID-123] my PR title
- multiple stories:
[PROJID-1,PROJID-2,PROJID-3] my PR title
Generated by :no_entry_sign: dangerJS against 4a52ba1978d0085ecc20476b04d283fec3170779
Codecov Report
Attention: Patch coverage is 59.09091%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 49.55%. Comparing base (
4f204b4
) to head (4a52ba1
). Report is 93 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5732 +/- ##
==========================================
+ Coverage 48.42% 49.55% +1.12%
==========================================
Files 1488 1619 +131
Lines 31617 32139 +522
Branches 7669 7771 +102
==========================================
+ Hits 15311 15926 +615
+ Misses 16238 16150 -88
+ Partials 68 63 -5
Files | Coverage Δ | |
---|---|---|
...fications/components/NotificationPreviewSample.tsx | 100.00% <ø> (ø) |
|
...ons/components/NotificationsPreferencesPreview.tsx | 100.00% <ø> (ø) |
|
...res/pushNotifications/hooks/usePreviewMoreInfo.tsx | 60.00% <ø> (ø) |
|
...cations/sagas/checkNotificationsPermissionsSaga.ts | 100.00% <ø> (ø) |
|
...cations/sagas/checkNotificationsPreferencesSaga.ts | 0.00% <ø> (ø) |
|
.../features/pushNotifications/sagas/notifications.ts | 85.18% <ø> (ø) |
|
...reens/OnboardingNotificationsInfoScreenConsent.tsx | 82.75% <100.00%> (ø) |
|
...reens/OnboardingNotificationsPreferencesScreen.tsx | 81.25% <100.00%> (ø) |
|
...s/pushNotifications/store/actions/notifications.ts | 100.00% <ø> (ø) |
|
...features/pushNotifications/store/reducers/index.ts | 100.00% <100.00%> (ø) |
|
... and 12 more |
... and 508 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 04c1105...4a52ba1. Read the comment docs.