io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat(IT Wallet): [SIW-979] Add issuing authentication mode selection screen

Open mastro993 opened this issue 9 months ago • 2 comments

Short description

This PR adds the authentication method selection screen, required for credentials issuing for the IT Wallet.

List of changes proposed in this pull request

  • Updated @pagopa/io-app-design-system to 1.36.6
  • Added ItwAuthModeSelectionScreen component
  • Added routes and params

How to test

Navigate to Profile > IT Wallet > Issuing, check that the new screen is correctly rendered.

Preview

mastro993 avatar Apr 30 '24 08:04 mastro993

Affected stories

  • 🌟 SIW-979: Come cittadino voglio scegliere il metodo di autenticazione preferito per continuare nel flusso di ottenimento eID subtask of

Generated by :no_entry_sign: dangerJS against 2006dd2fe20801713400bdd0e4d71de796971911

pagopa-github-bot avatar Apr 30 '24 08:04 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 48.91%. Comparing base (4f204b4) to head (2006dd2). Report is 51 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5729      +/-   ##
==========================================
+ Coverage   48.42%   48.91%   +0.48%     
==========================================
  Files        1488     1590     +102     
  Lines       31617    32019     +402     
  Branches     7669     7754      +85     
==========================================
+ Hits        15311    15661     +350     
- Misses      16238    16300      +62     
+ Partials       68       58      -10     
Files Coverage Δ
...features/itwallet/navigation/ItwStackNavigator.tsx 66.66% <ø> (ø)
ts/features/itwallet/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/profile/playgrounds/ItwPlayground.tsx 16.66% <0.00%> (-8.34%) :arrow_down:
...n/screens/ItwIdentificationModeSelectionScreen.tsx 4.54% <4.54%> (ø)

... and 197 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 789dbdc...2006dd2. Read the comment docs.

codecov[bot] avatar Apr 30 '24 08:04 codecov[bot]

Side note, should we rename authentication to identification? Does it makes sense to you since the citizen is already authenticated at this point?

Yes, it makes sense completely! I will make the change with the next commit.

mastro993 avatar May 07 '24 07:05 mastro993