io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOCOM-884] Green pass relevant screens, new DS

Open Vangaorth opened this issue 10 months ago • 2 comments

Short description

This PR adapts the relevant Green Pass' screens to the new DS.

Loading Generic Error Revoked
Loading GeneralError Revoked

List of changes proposed in this pull request

  • All Green Pass' screens have been converted to functional components
  • New DS on EuCovidCertGenericErrorKoComponent for a generic error while retrieving data
  • New DS on EuCovidCertLoadingScreen for a loading Green Pass
  • New DS on EuCovidCertRevokedScreen for a revoked Green Pass
  • Markdown component now supports an input number of lines to display the loading skeleton

How to test

Using the io-dev-api-server, generate messages for the Green Pass and check that all the screens listed above use the new DS. Check that every other types (for Green Pass' messages) work properly, even if their screens do not conform to the new DS.

Vangaorth avatar Apr 29 '24 16:04 Vangaorth

Affected stories

  • 🌟 IOCOM-884: [App] Adattare la schermata Green Pass di messaggio non più disponibile subtask of
    • IOCOM-817: Adottare il nuovo design system nel dettaglio di un messaggio Green Pass

Generated by :no_entry_sign: dangerJS against 422af6b07c587dd49367f215f352e579b22bb691

pagopa-github-bot avatar Apr 29 '24 16:04 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 69.79167% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 48.96%. Comparing base (4f204b4) to head (422af6b). Report is 46 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
+ Coverage   48.42%   48.96%   +0.54%     
==========================================
  Files        1488     1589     +101     
  Lines       31617    31976     +359     
  Branches     7669     7750      +81     
==========================================
+ Hits        15311    15658     +347     
- Misses      16238    16260      +22     
+ Partials       68       58      -10     
Files Coverage Δ
ts/components/ui/Markdown/Markdown.tsx 63.63% <100.00%> (+61.31%) :arrow_up:
...features/euCovidCert/components/EUCovidContext.tsx 100.00% <100.00%> (ø)
...tures/euCovidCert/components/EuCovidCertHeader.tsx 100.00% <ø> (ø)
ts/features/euCovidCert/navigation/navigator.tsx 66.66% <ø> (ø)
...CovidCert/screens/BaseEuCovidCertificateLayout.tsx 100.00% <100.00%> (ø)
...s/euCovidCert/screens/EuCovidCertExpiredScreen.tsx 83.33% <100.00%> (-4.17%) :arrow_down:
...s/euCovidCert/screens/EuCovidCertLoadingScreen.tsx 100.00% <100.00%> (ø)
...vidCert/screens/EuCovidCertificateRouterScreen.tsx 86.95% <100.00%> (-0.80%) :arrow_down:
...vidCert/screens/ko/EuCovidCertNotFoundKoScreen.tsx 83.33% <100.00%> (-2.39%) :arrow_down:
...t/screens/ko/EuCovidCertNotOperationalKoScreen.tsx 100.00% <100.00%> (ø)
... and 12 more

... and 177 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12ff9e2...422af6b. Read the comment docs.

codecov[bot] avatar Apr 29 '24 16:04 codecov[bot]