io-app
io-app copied to clipboard
feat: [PE-549] Adopt DS on CGN detail screen
Short description
This PR refactors the CGN detail screen to adopt the new DS Components
List of changes proposed in this pull request
- Changes
CgnDetailScreen
- Changes every child component for status information rendering
How to test
Check the CGN detail screen to be properly rendered.
https://github.com/pagopa/io-app/assets/3959405/ccdfff2c-f789-4490-b2a3-00a326af54cc
CGN Status | Screen |
---|---|
Active | Check below video 👇 |
Revoked | |
Expired |
Eyca Status | Screen |
---|---|
Active | |
Pending | |
Error |
Affected stories
- 🌟 PE-549: [FE] Revamp schermate dettaglio carta CGN
subtask of
- ⚡ PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0
Generated by :no_entry_sign: dangerJS against fca5de8ab5a4ef9a5c5d5b866dbbfaf503abcdf8
@CrisTofani the card borders look quite pixelated (and it looks like there's an inner offset with the animation). Is this going to be addressed in another PR?
@CrisTofani the card borders look quite pixelated (and it looks like there's an inner offset with the animation). Is this going to be addressed in another PR?
We need to properly export the asset giving the shape of the card, so we may just replace the asset here in the PR before merging
Codecov Report
Attention: Patch coverage is 37.75510%
with 61 lines
in your changes are missing coverage. Please review.
Project coverage is 48.89%. Comparing base (
4f204b4
) to head (fca5de8
). Report is 59 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5651 +/- ##
==========================================
+ Coverage 48.42% 48.89% +0.46%
==========================================
Files 1488 1602 +114
Lines 31617 32203 +586
Branches 7669 7807 +138
==========================================
+ Hits 15311 15746 +435
- Misses 16238 16389 +151
Partials 68 68
Files | Coverage Δ | |
---|---|---|
img/bonus/cgn/card_mask.png | 100.00% <ø> (ø) |
|
img/bonus/cgn/cgn_logo.png | 100.00% <ø> (ø) |
|
img/bonus/cgn/eyca_logo.png | 100.00% <ø> (ø) |
|
...ures/bonus/cgn/components/detail/CardSvgPayload.ts | 100.00% <100.00%> (ø) |
|
...es/bonus/cgn/components/detail/CgnStatusDetail.tsx | 100.00% <100.00%> (ø) |
|
ts/features/bonus/cgn/navigation/navigator.tsx | 70.00% <ø> (ø) |
|
...s/bonus/cgn/components/detail/CgnCardComponent.tsx | 92.85% <92.85%> (+1.94%) |
:arrow_up: |
...cgn/components/detail/eyca/EycaDetailComponent.tsx | 80.64% <83.33%> (ø) |
|
...ponents/detail/eyca/EycaStatusDetailsComponent.tsx | 66.66% <66.66%> (+16.66%) |
:arrow_up: |
...res/bonus/cgn/components/detail/CgnUnsubscribe.tsx | 5.88% <0.00%> (-0.37%) |
:arrow_down: |
... and 3 more |
... and 210 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3ab6f47...fca5de8. Read the comment docs.