io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IOBP-591] Refactor payments sagas to handle 401 status codes

Open mastro993 opened this issue 11 months ago • 2 comments

Short description

This PR refactors payments sagas to allow the correct handling of 401 status code and LV token refresh flows.

List of changes proposed in this pull request

  • Refactoring of payments feature sagas

How to test

Using the io-dev-api-server or the UAT environment, open the payments playground within the profile section:

  • Start and complete an onboarding
  • Start and complete a payment

mastro993 avatar Mar 15 '24 16:03 mastro993

Affected stories

  • ⚙️ IOBP-591: [Flusso TO-BE] Rimozione failure per status code 401 subtask of
    • IOBP-197: [MVP] Integrazione IO-ecommerce PagoPA (Flusso pagamento)

Generated by :no_entry_sign: dangerJS against 15ff9ecfe1653c3066db4f63eaa41e2a7a3d83bc

pagopa-github-bot avatar Mar 15 '24 16:03 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 41.71123% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 48.03%. Comparing base (3ae055f) to head (15ff9ec). Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5597      +/-   ##
==========================================
- Coverage   48.04%   48.03%   -0.02%     
==========================================
  Files        1436     1436              
  Lines       30996    31057      +61     
  Branches     7563     7583      +20     
==========================================
+ Hits        14892    14917      +25     
- Misses      16033    16069      +36     
  Partials       71       71              
Files Coverage Δ
ts/features/payments/details/saga/index.ts 0.00% <ø> (ø)
...s/features/payments/details/store/actions/index.ts 100.00% <ø> (ø)
...aga/networking/handleWalletPaymentGetAllMethods.ts 84.21% <100.00%> (+4.21%) :arrow_up:
...a/networking/handleWalletPaymentNewSessionToken.ts 85.00% <100.00%> (+3.75%) :arrow_up:
...omponents/WalletDetailsPagoPaPaymentCapability.tsx 7.69% <0.00%> (ø)
...ls/components/WalletDetailsPaymentMethodScreen.tsx 11.42% <0.00%> (ø)
...aga/networking/handleWalletPaymentCalculateFees.ts 80.64% <88.88%> (+1.33%) :arrow_up:
...networking/handleWalletPaymentCreateTransaction.ts 77.27% <84.61%> (+0.80%) :arrow_up:
...aga/networking/handleWalletPaymentAuthorization.ts 77.27% <76.92%> (-3.98%) :arrow_down:
...t/saga/networking/handleWalletPaymentGetDetails.ts 77.27% <78.57%> (+0.80%) :arrow_up:
... and 8 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ae055f...15ff9ec. Read the comment docs.

codecov[bot] avatar Mar 15 '24 16:03 codecov[bot]