io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IA-946] Add the feature flag for enabling the reminders opt-in in app

Open emiliopavia opened this issue 2 years ago • 5 comments

Short description

This PR introduces a feature flag for the reminder push notifications opt-in in the app. The feature will be off in production until ready.

emiliopavia avatar Sep 30 '22 07:09 emiliopavia

Affected stories

  • 🌟 IA-946: Aggiungere feature flag locale subtask of
    • 🌟 IA-945: Come CIT voglio potere ricevere notifiche di promemoria

Generated by :no_entry_sign: dangerJS against 1ae80a5e1cf9518c27933ba1b87eab5949eaaae8

pagopa-github-bot avatar Sep 30 '22 07:09 pagopa-github-bot

Codecov Report

Merging #4126 (1ae80a5) into master (5f06bc3) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4126   +/-   ##
=======================================
  Coverage   47.75%   47.75%           
=======================================
  Files        1263     1263           
  Lines       25003    25004    +1     
  Branches     6546     6546           
=======================================
+ Hits        11940    11941    +1     
  Misses      13013    13013           
  Partials       50       50           
Impacted Files Coverage Δ
ts/config.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f06bc3...1ae80a5. Read the comment docs.

codecov[bot] avatar Sep 30 '22 07:09 codecov[bot]

what about adding the remote FF too?

@CrisTofani do you think it's needed at this stage?

emiliopavia avatar Oct 10 '22 13:10 emiliopavia

what about adding the remote FF too?

@CrisTofani do you think it's needed at this stage?

We usually handle in a single PR but if you prefer let's face the problem in a separated PR

CrisTofani avatar Oct 12 '22 11:10 CrisTofani

We usually handle in a single PR but if you prefer let's face the problem in a separated PR

@CrisTofani I mean, I'm not even sure we need a remote FF here. It's just a new profile setting to be set during the first onboarding.

emiliopavia avatar Oct 17 '22 06:10 emiliopavia