io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IAI-235] Add `Pictogram` and `SectionPictogram` components

Open dmnplb opened this issue 1 year ago • 2 comments

Short description

⚠️ This PR depends on #4101

This PR adds Pictogram and SectionPictogram components with the goal of giving a tidier way to insert vector assets in the application. Pictogram component includes all the decorative pictograms, SectionPictogram all the pictograms associated to sections (Messages, Profile, Settings, etc…).

From now on, you can insert a pictogram in the following way:

{/* Insert the pictogram Umbrella with default
120 × 120 size and `aqua` default color */}
<Pictogram name="umbrella" />

Preview

SectionPictogram Pictogram
Simulator Screen Shot - iPhone 13 - 2022-08-09 at 14 44 04 Simulator Screen Shot - iPhone 13 - 2022-08-09 at 14 44 23

List of changes proposed in this pull request

  • Add new Pictogram component with relative types
  • Add new SectionPictogram component with relative types
  • Add the local README to give proper documentation

How to test

  • Start the IO app with yarn run-ios
  • Login to the app
  • Go to the Profile → UI Showroom

dmnplb avatar Aug 10 '22 11:08 dmnplb

Affected stories

  • ⚙️ IAI-235: Aggiunta di un componente per la gestione dei pittogrammi subtask of
    • ⚙️ IAI-222: Gestione degli asset (immagini, icone, pittogrammi)

Generated by :no_entry_sign: dangerJS against eb5bcf08403357734fc0c35023301a6c4e2f97b1

pagopa-github-bot avatar Aug 10 '22 11:08 pagopa-github-bot

Codecov Report

Merging #4102 (0d18d5d) into master (f4883fc) will decrease coverage by 0.00%. The diff coverage is 45.34%.

:exclamation: Current head 0d18d5d differs from pull request most recent head eb5bcf0. Consider uploading reports for the commit eb5bcf0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4102      +/-   ##
==========================================
- Coverage   47.82%   47.81%   -0.01%     
==========================================
  Files        1299     1336      +37     
  Lines       25519    25605      +86     
  Branches     6683     6687       +4     
==========================================
+ Hits        12205    12244      +39     
- Misses      13263    13310      +47     
  Partials       51       51              
Impacted Files Coverage Δ
ts/screens/showroom/components/AssetViewerBox.tsx 27.77% <ø> (ø)
ts/screens/showroom/core/PictogramsShowroom.tsx 40.00% <0.00%> (-26.67%) :arrow_down:
ts/components/core/pictograms/Pictogram.tsx 28.57% <28.57%> (ø)
ts/components/core/pictograms/PictogramSection.tsx 28.57% <28.57%> (ø)
...components/core/pictograms/svg/PictogramAbacus.tsx 50.00% <50.00%> (ø)
...ponents/core/pictograms/svg/PictogramAirBaloon.tsx 50.00% <50.00%> (ø)
...omponents/core/pictograms/svg/PictogramAirship.tsx 50.00% <50.00%> (ø)
...omponents/core/pictograms/svg/PictogramBaloons.tsx 50.00% <50.00%> (ø)
...omponents/core/pictograms/svg/PictogramBeerMug.tsx 50.00% <50.00%> (ø)
...ponents/core/pictograms/svg/PictogramCompleted.tsx 50.00% <50.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4883fc...eb5bcf0. Read the comment docs.

codecov[bot] avatar Aug 10 '22 12:08 codecov[bot]