io-app
io-app copied to clipboard
chore: [IAI-164] Upgrade `WalletNavigator` to v5
Short description
This PR aims to upgrade the base WalletNavigator to the v5 definition of react-navigation
How to test
Navigate through wallet sections and subcomponents.
NOTE: this PR is the starting point to later update all the Bpd child navigators. The BPD feature navigators and screens still need to support Compat mode.
Affected stories
- ⚙️ IAI-164: Aggiornare il navigator per il Wallet
subtask of
- ⚡ IAI-143: Preparing for react-navigation v6
Generated by :no_entry_sign: dangerJS against 84b17070aca19e3049379430db5e82191e5cd648
Codecov Report
Merging #4097 (b7fba40) into master (4c7f4a5) will decrease coverage by
0.04%
. The diff coverage is25.00%
.
:exclamation: Current head b7fba40 differs from pull request most recent head 84b1707. Consider uploading reports for the commit 84b1707 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
- Coverage 47.01% 46.96% -0.05%
==========================================
Files 1293 1292 -1
Lines 25841 25787 -54
Branches 6894 6876 -18
==========================================
- Hits 12150 12112 -38
+ Misses 13640 13626 -14
+ Partials 51 49 -2
Impacted Files | Coverage Δ | |
---|---|---|
...s/bonus/bonusVacanze/screens/ActiveBonusScreen.tsx | 10.48% <0.00%> (ø) |
|
ts/features/pn/components/PnMessageDetails.tsx | 3.22% <ø> (+0.05%) |
:arrow_up: |
...es/wallet/bancomat/screen/BancomatDetailScreen.tsx | 33.33% <0.00%> (ø) |
|
...ures/wallet/cobadge/screen/CobadgeDetailScreen.tsx | 60.00% <0.00%> (ø) |
|
...n/screens/bpd/ActivateBpdOnNewCreditCardScreen.tsx | 50.00% <ø> (ø) |
|
.../wallet/privative/screen/PrivativeDetailScreen.tsx | 60.00% <0.00%> (ø) |
|
...es/wallet/satispay/screen/SatispayDetailScreen.tsx | 60.00% <0.00%> (ø) |
|
ts/navigation/AppStackNavigator.tsx | 47.91% <ø> (ø) |
|
...screens/wallet/AddCreditCardOutcomeCodeMessage.tsx | 40.00% <ø> (ø) |
|
ts/screens/wallet/AddPaymentMethodScreen.tsx | 33.33% <0.00%> (ø) |
|
... and 39 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4c7f4a5...84b1707. Read the comment docs.
I found a crash here:
Screen.Recording.2022-08-30.at.15.47.26.mov It's probably relative to
ActiveBonusScreen
still using thecompat
layer!
@dgopsq fixed in d9c86b5
@CrisTofani in my tests everything seems to work (I've only fixed 630fa55). I'm accepting this, however if you agree I would merge this after the next release, in order to have an entire cycle of beta testing.
@emiliopavia for sure! 100% agree that this PR needs a complete beta testing process before store delivering!