io-app
io-app copied to clipboard
chore: [IAI-232] Remove/Update references to color values
Short description
⚠️ This PR depends on #4062
This PR updates all the references to plain color values, removing the unnecessary ones. Now all the basic color values in the variables.ts
are associated to IOColors
values (except ones related to typography)
Preview
Before Look at the video in the PR #4057
After
List of changes proposed in this pull request
- Remove redundant values of
blue
- Remove
Italia blue
tint (#0066d3
) - Rename secondary colours with a name referred to the tint, not the function (e.g:
cobalt
instead ofcgn…
) - Delete similar tones of
aqua
- Change
brandSuccess
tint with a new green color value, according to the design specs - Leave lighter tints of
blue
andaqua
because they're still used in some components - Leave
noCieButton
tint, but the color value will be probably deleted during the refactor
How to test
- Start the IO app with
yarn run-ios
- Login to the app
- Go to the Profile → UI Showroom
Affected stories
- ⚙️ IAI-232: Eliminazione dei riferimenti duplicati dei colori restanti (primary, secondary, etc…)
subtask of
- ⚙️ IAI-215: Eliminazione delle variabili multiple dello stesso colore
Generated by :no_entry_sign: dangerJS against 095c4ca38247eb0fb240b0596c8bd46b5890e772
:tada: All dependencies have been resolved !
@dmnplb if you agree, I'll review this PR after you resolve those merge conflicts, ok? Thanks!
Codecov Report
Merging #4075 (095c4ca) into master (2f4f22b) will increase coverage by
0.00%
. The diff coverage is42.85%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #4075 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 1264 1264
Lines 25034 25030 -4
Branches 6555 6553 -2
=======================================
- Hits 11957 11956 -1
+ Misses 13027 13024 -3
Partials 50 50
Impacted Files | Coverage Δ | |
---|---|---|
ts/components/Pinpad/KeyPad.tsx | 16.66% <ø> (ø) |
|
ts/components/RegionServiceWebView.tsx | 4.16% <ø> (ø) |
|
ts/components/RemindEmailValidationOverlay.tsx | 7.82% <ø> (ø) |
|
ts/components/core/variables/IOColors.ts | 100.00% <ø> (ø) |
|
ts/components/infoScreen/imageRendering.tsx | 60.00% <ø> (ø) |
|
...ts/messages/paginated/MessageDetail/DueDateBar.tsx | 98.00% <ø> (ø) |
|
ts/components/screens/BaseHeader.tsx | 81.91% <0.00%> (ø) |
|
ts/components/wallet/PaymentsHistoryList.tsx | 10.34% <ø> (ø) |
|
ts/components/wallet/card/SectionCardComponent.tsx | 9.52% <ø> (ø) |
|
...s/bonus/bonusVacanze/screens/ActiveBonusScreen.tsx | 9.80% <ø> (ø) |
|
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2f4f22b...095c4ca. Read the comment docs.
@emiliopavia @dmnplb is this PR ready to be reviewed and merged?
@emiliopavia @dmnplb is this PR ready to be reviewed and merged?
We don't have UI regression tests (with visual snapshots) yet, so we should check all the app sections with different user scenarios (both on iOS and Android) to be almost sure we don't add visual regressions. Of course I already did that by myself (except on Android) but it's not enough.
@dmnplb Update to master so we can merge.