io-app
io-app copied to clipboard
Gentle and progressive fp-ts migration
Short description
I want to collect your opinion about a different way of migrate to fp-ts v2 in a gentle and progressive way. Don't focus on the quality or the correctness of the migration but only on the wide scenario. I am going to comment my own PR to better highlight important points
List of changes proposed in this pull request
- Gentle and progressive migration to fp-ts 2. Progressive means that fp-ts v1 and v2 coexist in the codebase until fully ported
How to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Warnings | |
---|---|
:warning: | Please include a Pivotal story or Jira ticket at the beginning of the PR title |
Example of PR titles that include pivotal stories:
- single story:
[#123456] my PR title
- multiple stories:
[#123456,#123457,#123458] my PR title
Example of PR titles that include Jira tickets:
- single story:
[PROJID-123] my PR title
- multiple stories:
[PROJID-1,PROJID-2,PROJID-3] my PR title
Generated by :no_entry_sign: dangerJS against 06f73cbf2d12c47c702a8cf7d2fa40ca09e76c52
Codecov Report
Merging #4044 (06f73cb) into master (4d1fd21) will increase coverage by
0.00%
. The diff coverage is61.53%
.
@@ Coverage Diff @@
## master #4044 +/- ##
=======================================
Coverage 47.25% 47.25%
=======================================
Files 1256 1257 +1
Lines 25269 25277 +8
Branches 6735 6735
=======================================
+ Hits 11941 11945 +4
- Misses 13279 13283 +4
Partials 49 49
Impacted Files | Coverage Δ | |
---|---|---|
...sagas/startup/watchLoadMessageWithRelationsSaga.ts | 0.00% <0.00%> (ø) |
|
ts/migration/fp-ts-converters.ts | 50.00% <50.00%> (ø) |
|
ts/sagas/messages/loadMessage.ts | 91.66% <83.33%> (+0.36%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4d1fd21...06f73cb. Read the comment docs.
This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.
closing since the merge of #4020