primer icon indicating copy to clipboard operation
primer copied to clipboard

Favicon support?

Open seshrs opened this issue 4 years ago • 4 comments

It would be nice if the Primer theme could add support for favicons. Spefically, it would be nice if default.html could add a <link rel="icon"> tag to the page if a favicon option is specified in _config.yml.

I first considered whether the Favicon should be included as part of the Jekyll SEO tag. However, I don't think the plugin should offer support for favicons, especially given its focus on generating machine-readable metadata for search engines and social networks.

I'm happy to open a PR to add favicon support — it should be extremely straightforward — but I wanted to ask for opinions before I do so. Comments and suggestions would be appreciated 😃

seshrs avatar Sep 07 '20 19:09 seshrs

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 25 '20 14:12 stale[bot]

Bump on this. I’ll go ahead and open a PR too :)

seshrs avatar Dec 25 '20 14:12 seshrs

This would be amazing!

MeesJ avatar Apr 18 '21 14:04 MeesJ

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 02:01 stale[bot]