Add styles for tasklist

[davorpa]

Generate styles for tasklist preserving theme colors

to

A complete implement for pages-themes/hacker#75. Resolves #75

Preview a demo at https://davorpa.github.io/github-pages-themes-hacker/#what-about-task-lists

[davorpa]

@parkr could you approval me to workflow?

It works like a charm and my build pass. See davorpa/github-pages-themes-hacker#5

[jimhall]

This is a great idea and simple implementation.

[davorpa]

This LGTM, though it would be great to test this on all major browsers.

• What is the pointcut?

Some feedback in my scope.

Windows - Chrome

As seen as in PR description. I dont remember the version I took the snapshot with :worried:. Now I have 94.0.4606.81 and it looks the same.

Windows - Edge 94.0.992.38

Windows - IE 11.0.9600.19596 or minor

Need fix. Maybe due to missing ms- vendor property Not supported :cry:

• https://css-tricks.com/almanac/properties/a/appearance/
• https://caniuse.com/mdn-css_properties_appearance_none

Here some pointcut CSS hacks: https://browserstrangeness.bitbucket.io/css_hacks.html

[jimhall]

Still better than what we started with!

[parkr]

I believe Microsoft is trying to migrate to Edge and away from Internet Explorer, so this shouldn't be a huge issue.

Safari, Chrome, and Firefox on Mac look good to me.

:shipit:

[parkr]

(I left GitHub and can't merge this, but I give it my approval!)

[davorpa]

Still better than what we started with!

I have in my backlog apply some IE11- hack to remove this decoration. I'll also try to increase checkboxes size to be pixel perfect more or less.

[rabooli]

در تاریخ چهارشنبه ۱۳ اکتبر ۲۰۲۱،‏ ۲۳:۱۰ David Ordás < @.***> نوشت:

Still better than what we started with!

I have in my backlog apply some IE11- hack to remove this decoration. I'll also try to increase checkboxes size to be pixel perfect more or less.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pages-themes/hacker/pull/83#issuecomment-942657218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOOITSZLOC6I3O7AUW5JWFLUGXOELANCNFSM5DDFHWQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jimhall]

Would prefer this kept open.

[davorpa]

Bump