cayman icon indicating copy to clipboard operation
cayman copied to clipboard

use css vars and @media queries to change colours depending on device theme

Open godalming123 opened this issue 2 years ago • 9 comments

We must use css vars because you can change them depending on whether the device is using light or dark theme and there is documentation on media quirys at https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme. to see what it looks like turn dark mode on for your device and visit https://godalming123.github.io/cayman/

godalming123 avatar Aug 18 '21 17:08 godalming123

Welcome! Congrats on your first pull request to the Cayman theme. If you haven't already, please be sure to check out the contributing guidelines.

welcome[bot] avatar Aug 18 '21 17:08 welcome[bot]

I've bin' tryin to make the web just a liddle dark over the past few days

godalming123 avatar Aug 18 '21 18:08 godalming123

theme nearly ready

godalming123 avatar Aug 20 '21 15:08 godalming123

I have a working branch in https://github.com/godalming123/cayman/tree/support-for-changing-theme-with-_config.yaml this will allow you to change color-scheme based on config.yaml option however the only problem is it doesn't deafualt to auto theme so if you do not set color-scheme: dark | light | auto | auto-deafualt-dark then the document will no have any colors. Currently the github pages instance is based on this branch so just go to https://godalming123.github.io/cayman/ to see working prototype.

godalming123 avatar Aug 24 '21 09:08 godalming123

Just added support for changing the theme with a config.yaml option that deafualts to auto in patch-1 branch!

godalming123 avatar Aug 26 '21 08:08 godalming123

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 23:01 stale[bot]

this is not stale

godalming123 avatar Jan 09 '22 14:01 godalming123

This is useful functionality! Just say the repo is unmaintained

godalming123 avatar Jan 09 '22 16:01 godalming123

@markblokpoel thank you for finding these issues, I will see if I ever get time to fix them but don't get your hopes up. I kinda gave up on this when I realised that it will not be used in production if it is not merged; the Cayman theme is already being pushed by the github pages GUI but has little users, how many of them will switch to this theme when it requires realising that their are more themes then the ones suggested by the github pages GUI and others likely do a better job for their needs. And I doubt it will be merged based on the number of garbage changes that haven't been closed.

godalming123 avatar Jul 31 '23 16:07 godalming123