pagermon icon indicating copy to clipboard operation
pagermon copied to clipboard

A new Plugin and a fix for the Telegram Plugin

Open alphaO4 opened this issue 1 year ago • 5 comments

Description

I did two things. First I created a completly new Plugin, called Meshtastics LoRa API. This Plugin uses the python CLI from Meshtastic to send messages to certain chat ID's. This is extremly usefull for cases where there might not be a working cellular connection, since these Meshtastic devices work completle OffTheGrid.

Dependencies: Meshtastics Python CLI

The Second thing is, that I updated the Telegram Plugin to be able to handle multible chat-id's. This is usefull in case you don't want to create a Telegram group, or you want to send different Alarms to multible Telegram Users/Groups. Both, Users and Groups can be given simultainiously. (Tho only in ID form) Please note, that I disabled the Markdown in "sendMessage()", since it caused an escape character error with encrypted POCSAG messages, that had an escape character.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [X] This change requires a documentation update

How Has This Been Tested?

I tested this both under test conditions (with the ./sampleMessage.sh) and under real world continions. These changes are now running for a week in a "prod" enviroment, without any problems.

  • [X] Using ./testMessage.sh to trigger aliases and therefore Messages
  • [x] Letting it run in prod

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have updated changelog.md with changes made

alphaO4 avatar May 12 '23 21:05 alphaO4

This also closes the branch "feature-telegram-multiple-targets"

alphaO4 avatar May 12 '23 21:05 alphaO4

We don't merge directly into master, please modify to merge into develop first.

DanrwAU avatar May 13 '23 03:05 DanrwAU

We will also likely need to vigorously test the telegram plugin changes. Not because theres something wrong with your code, but because we actually had a multi destination telegram plugin and had to frantically revert it for.. reasons.

geelongmicrosoldering avatar May 13 '23 03:05 geelongmicrosoldering

Perfekt, I will make the changes as soon as I'm home from work.

alphaO4 avatar May 13 '23 05:05 alphaO4

We will also likely need to vigorously test the telegram plugin changes. Not because theres something wrong with your code, but because we actually had a multi destination telegram plugin and had to frantically revert it for.. reasons.

So far, I didn't have any problems, with regular Strings, of any length. What where the problems you guys encountered?

alphaO4 avatar May 13 '23 05:05 alphaO4