rogueserver icon indicating copy to clipboard operation
rogueserver copied to clipboard
Published 5 months ago • verified publisher icon pagefaultgames

Installation instructions have the wrong line numbers

Open amuck-gorilla opened this issue 1 year ago • 2 comments

In the README's instructions for installation, the line numbers in the title of the linked section are incorrect and indicate the wrong part of the file. https://github.com/pagefaultgames/rogueserver?tab=readme-ov-file#srcutilsts224-225-in-pokerogue I've already submitted a PR to fix this, right here: #45

amuck-gorilla avatar Jul 03 '24 14:07 amuck-gorilla

I noticed that the line number has changed again. Maybe it is better to modify Vite environment configuration in .env.production.

VITE_SERVER_URL=https://api.pokerogue.net

KuramiWan avatar Aug 31 '24 06:08 KuramiWan

@KuramiWan Maybe it is better, I don't know. I've kind of let this PR fall by the wayside, since I found out on the Discord that Pancakes is busy and this probably isn't going to be addressed anytime soon. I don't care enough about this issue to keep the PR up-to-date for that long. Feel free to open your own PR, but I'm honestly considering whether to delete my PR or just update it when Pancakes is eventually available.

amuck-gorilla avatar Sep 01 '24 21:09 amuck-gorilla