pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Promise Rework

Open brain-frog opened this issue 9 months ago • 4 comments

This is the beginning of a big cleanup, please test thoroughly

brain-frog avatar May 15 '24 17:05 brain-frog

just saw this, seems like it will conflict with the changes I made in PR #783

skimming through there will me merge conflicts, but doesn't seem like the functionality or the change will be impacted? Especially looking at pokemon.ts and phases.ts

DustinLin avatar May 15 '24 18:05 DustinLin

just saw this, seems like it will conflict with the changes I made in PR #783

skimming through there will me merge conflicts, but doesn't seem like the functionality or the change will be impacted? Especially looking at pokemon.ts and phases.ts

@DustinLin No part of this should change functionality, its cleaning up the code to be more readable and use async/Promises cleaner

brain-frog avatar May 15 '24 22:05 brain-frog

looked and did some testing (with my changes) and everything seems ok from my perspective

DustinLin avatar May 16 '24 15:05 DustinLin

small thing i noticed though is multi-hit move animations are faster now? check out the 2 clips

(these changes could also be whatever was merged into main but figured point them out here since it may be related)

---- NEW

https://github.com/pagefaultgames/pokerogue/assets/39450497/73921078-656f-492d-be5c-1f094f7c8ada

---- OLD

https://github.com/pagefaultgames/pokerogue/assets/39450497/87f4fbb0-d2dc-425f-b31a-9e16b6d0a50b

DustinLin avatar May 16 '24 15:05 DustinLin

closing this to restart and test more thoroughly along the way

brain-frog avatar May 22 '24 15:05 brain-frog