Fix False Trigger of Corrosion

[Brandon-Rodgers]

Issue: Corrosion triggers when moves use getTargetBenefitScore even if the move is not actually used by the opponent.

Fix: Moved IgnoreTypeStatusEffectImunity to extend from PreSetStatusAbAttr instead of AbAttr so I can use the existing implemented quiet arg.

Extras: I changed simulated to just use the first arg which is how the current checks pass the quiet arg.

I was able to remove effect from args and have it as a set parameter being passed

https://github.com/pagefaultgames/pokerogue/assets/9848614/0bfc926d-9ddb-4915-ae05-e78a9e989a5d

[DustinLin]

Just curious I'm a bit confused on the original problem, can you provide an example? Are you saying a non-poison move will trigger the ability? Providing a before fix demo could help the reviewers also

[Brandon-Rodgers]

Just curious I'm a bit confused on the original problem, can you provide an example? Are you saying a non-poison move will trigger the ability? Providing a before fix demo could help the reviewers also

Every time the AI's goes they trigger the Corrosion pop-up even if they do not use a move that would trigger it like poison. This fix makes it so when the AI is trying to select a move they do not trigger the Corrosion pop-up. It will now only trigger when a move actually is used to trigger it. See below for videos of the issue.

Salazzle has Poison Powder, and 3x Dragon Dance moves. Uses Dragon Dance and corrosion triggers

https://github.com/pagefaultgames/pokerogue/assets/9848614/9c5f63b3-dec2-46da-9059-be9bfc43dee6

Salazzle only has Dragon Dance and no moves that would proc corrosion. Uses Dragon Dance and corrosion does not trigger

https://github.com/pagefaultgames/pokerogue/assets/9848614/76a0a1f1-3bd7-4523-9b49-6f41785fc3b5

[flx-sta]

No action within more than a month. Considered stale.

Feel free to re-open it when you are still working on it/want to work on it again