pokerogue
pokerogue copied to clipboard
Automatically center window vertically when playing on landscape
Resolves enhancement #810
- Since other players like to play on portrait mode (top - game window, bottom - controls), we'd center vertically on landscape mode only
I really preferred the implementation here: https://github.com/pagefaultgames/pokerogue/pull/849
I made the changes in that PR to my own instance and it has been fantastic:
I've been playing on iPad as a PWA, mirroring to Apple TV, and honestly really preferred having the option. When attached to a keyboard, I center the game screen and hide the touch controls. If the keyboard isn't attached, I move it back to the top and have touch controls on, and having it at the top helps keep the controls out of the way.
I never hold my iPad in portrait unless I'm reading something long, so this is all landscape orientation.
I'm down for both but it will actually boil down to user preference still and what the devs think
For reference, this is what it looks like on a device with landscape orientation using steam deck's screen size:
BEFORE:
AFTER:
Now that I compare them, I personally think the before is actually better user experience for handheld devices that DO NOT have built in controls because of the bottom space it provides (still depending on screen size) and vice versa.
https://github.com/pagefaultgames/pokerogue/assets/68144167/158a834e-5dca-4767-b295-adb03821e661
iPad PWA screenshots
Default
Centered with Touch
Centered without Touch