pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Automatically center window vertically when playing on landscape

Open torranx opened this issue 9 months ago • 4 comments

Resolves enhancement #810

  • Since other players like to play on portrait mode (top - game window, bottom - controls), we'd center vertically on landscape mode only

torranx avatar May 14 '24 04:05 torranx

I really preferred the implementation here: https://github.com/pagefaultgames/pokerogue/pull/849

I made the changes in that PR to my own instance and it has been fantastic:

I've been playing on iPad as a PWA, mirroring to Apple TV, and honestly really preferred having the option. When attached to a keyboard, I center the game screen and hide the touch controls. If the keyboard isn't attached, I move it back to the top and have touch controls on, and having it at the top helps keep the controls out of the way.

I never hold my iPad in portrait unless I'm reading something long, so this is all landscape orientation.

grenlith avatar May 15 '24 06:05 grenlith

I'm down for both but it will actually boil down to user preference still and what the devs think

torranx avatar May 15 '24 06:05 torranx

For reference, this is what it looks like on a device with landscape orientation using steam deck's screen size:

BEFORE: Screenshot 2024-05-15 at 3 02 38 PM

AFTER: Screenshot 2024-05-15 at 3 03 46 PM

Now that I compare them, I personally think the before is actually better user experience for handheld devices that DO NOT have built in controls because of the bottom space it provides (still depending on screen size) and vice versa.

https://github.com/pagefaultgames/pokerogue/assets/68144167/158a834e-5dca-4767-b295-adb03821e661

torranx avatar May 15 '24 07:05 torranx

iPad PWA screenshots

Default image

Centered with Touch image

Centered without Touch image

grenlith avatar May 15 '24 07:05 grenlith