pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Fixed clear freeze in offline mode

Open Nexllon opened this issue 9 months ago • 2 comments

Currently when in offline mode, api "savedata/newclear" gets called to check dailyRun seed every handleGameOver(). Added a simple isLocal check to prevent that since it was causing freezes when playing classic offline.

Nexllon avatar May 12 '24 19:05 Nexllon

Oh cool, you did that for me! I'll note that this does fix the problem but I think this also lets you redo dailies to get the same reward multiple times.

Of course, if you're playing in offline mode you can already do far crazier shenanigans if you want to cheese the system, and the daily run isn't even a consideration unless some other code is changed to add it to offline, but it's worth noting regardless.

Admiral-Billy avatar May 12 '24 19:05 Admiral-Billy

export const isLocal = window.location.hostname === 'localhost' || window.location.hostname === '';

How easy is this to spoof to be false

As easy as anything else in the game client (pretty)

Nexllon avatar May 13 '24 11:05 Nexllon

@Flashfyre since the issue with this PR is correlated to #808 that is not yet implemented (and will be fixed). Could we push this and fix in the other issue? Or just close this one and I'll merge everything in the other one too.

Nexllon avatar May 13 '24 20:05 Nexllon