pokerogue
pokerogue copied to clipboard
pagefaultgames
Summary text as images
Some of the text found in the summary are images. We should probably:
- Remove the text from the images and insert the text programatically
- Or create several images for each lang.
I would prefer the first solution. Then it is easier to add new languages
Furthermore, also for any HUD element like "Lv.", "HP" or "Exp" on the battle screen, and stats names when you toggle current boosts.
Personnaly, I would prefer the second solution, create several images for each lang. It would give use a precise control, and prevent any font compatibility issues from a language to another, as currently exists in regular texts with Simplified Chinese.
Well look how i changed the font size based on the language here:
https://github.com/pagefaultgames/pokerogue/pull/797
So we can make the "bad" text smaller if it is currently showing chinese
Even without font issues, I personally still think it would be better to have localized images. Visually, it would help to keep the style, and not taking the risk of something visually incoherent and cranky
Even without font issues, I personally still think it would be better to edit images. Visually, it would help to keep the style, and not taking the risk of something visually incoherent and cranky
While this is true. It is a lot more work then to add a new language.
There are already PRs for Korean, Japanese and Portugese (Brazil). And probably there will be more.
Also this will increase file size a lot no? If we have every image for every language
Translated elements can just be switchable tiles or tiles overlaid on a base blank HUD, but not a whole version of the HUD per language. So I highly doubt it would be heavy in any way. I'm aware it might be more difficult for dev to implement, but on my opinion, it's better to take time to do this than choosing the easy path and ending with something of lower quality
Okay.
I already have made an issue for the type symbols (that creates the images we can later integrate).
https://github.com/pagefaultgames/pokerogue/issues/755
Maybe we can do something similar for the rest?
I admit I'm not quite conviced it would fit for the HUD, what your proposion seem to be is bascally the 1st solution, but glorified. It would have the same issues, like not having the correct font (which might not exists at all in some precise cases) or fonts that do not support non-latin writing systems
As an example, in Italian "EXP" will have to be translated as "ESP", and in that case, I can't figure how what you are proposing can work. There is no font for it, so it has to be a handmade image tile
Same for HP, being "PV" in French or "PS" in Spanish, among others
I admit I'm not quite conviced it would fit for the HUD, what your proposion seem to be is bascally the 1st solution, but glorified. It would have the same issues, like not having the correct font (which might not exists at all in some precise cases) or fonts that do not support non-latin writing systems
As an example, in Italian "EXP" will have to be translated as "ESP", and in that case, I can't figure how what you are proposing can work. There is no font for it, so it has to be a handmade image tile
Same for HP, being "PV" in French or "PS" in Spanish, among others
Sorry to ask this. But did you actually look at the code i have done?
For chinese there is a special font used since the font the western languages use does not have chinese symbols in it.
The same could be done for japanese, korean etc.
Also why couldnt the images for EXP and HP be generated that way? I am already giving the function the text it should put in the image. So for italian it can put ESP and for english EXP
Also we would need a font to create the images (unless you want to handdraw them pixel by pixel...)
But if you think we should not use what i have created its fine. I can close that issue.
Just wanted to make sure we discussed this
Yes I saw what you did and think it's fantastic, however it wont be fathful if we don't have the precise original font. Unless Flashfyre allow liberties in the art style, but it's not mine to descide of course, I'm just giving my opinion.
Also we would need a font to create the images (unless you want to handdraw them pixel by pixel...)`
I love doing this kind of pixel work, so it would not bother me to hand draw just a few words with letters of 6px tall, but I understand it's not everyone's kink
I will close my issue, it is still linked here so if we decide to use it fine. But i dont think it should be its own issue no matter what