pokerogue
pokerogue copied to clipboard
pagefaultgames
Fix Curse targeting for non ghost types
Added a new MoveTarget type, MoveTarget.CURSE especifically for the move, so that it only makes you choose target if you are a ghost type (or tera into ghost). I don't believe many moves with variable targeting will be added so I think it's okay to fix it like this.
This should fix the bugs related to this move, such as the ones mentioned in issues https://github.com/pagefaultgames/pokerogue/issues/537 and https://github.com/pagefaultgames/pokerogue/issues/779
But isnt curse also beeing able to be used by non ghost types?
https://bulbapedia.bulbagarden.net/wiki/Curse_(move)
Maybe i am missunderstanding somehting
But isnt curse also beeing able to be used by non ghost types?
https://bulbapedia.bulbagarden.net/wiki/Curse_(move)
Maybe i am missunderstanding somehting
Yes, it still allows non ghost types to use it, but they don't have to choose a target anymore, since it becomes a self targeting move and gives +1 Attack, Defense and -1 Speed
Doesn't tera starstorm have variable targeting? If terapagos is not terrastalized then it is single target, and if it is terastellized then it is multi target and should skip asking for a target.
Nice! Didn't consider making a new MoveTarget category since this is such a minor edge case that I think only curse has conditional targeting. Have you tested that this works?
Yes, it does work perfectly, though I haven't tested every edge situation, just did a double battle with a ghost type and a non ghost type and the first could choose target and the second couldn't. The animations also played as expected.
Doesn't tera starstorm have variable targeting? If terapagos is not terrastalized then it is single target, and if it is terastellized then it is multi target and should skip asking for a target.
You are right, I may do another PR for that, though I want to keep this one for Curse