pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Implement Parental Bond

Open jaimefd opened this issue 9 months ago • 2 comments

Implemented the ability Parental Bond, with a new ExtraHitMoveAbAttr that takes two values, the amount of extra hits and the damage modifier for them (in this case 1 and 0.25).

From my testing it seems to work like original Pokemon, with the exception that I intentionally allowed it to activate with Multi-Hit moves, so that it doesn't become redundant with Multi Lens and so that Maushold makes sense with Parental Bond as passive (otherwise it would be a useless passive). This can be changed easily if needed.

Tested that non-attacking moves don't activate it, misses also stop the second hit, and it procs secondary effects as expected.

jaimefd avatar May 12 '24 16:05 jaimefd

How does this look/feel visually with long animations? Can we get a video with an example?

bennybroseph avatar May 13 '24 07:05 bennybroseph

Does this deal with all the edge cases listed on bulbapedia?

If a move could hit multiple targets (including allies), such as Earthquake and Rock Slide, it will not strike twice; however, if it can only hit a single Pokémon, such as in a Single Battle or if using a move that can hit multiple targets when only one target is in range, it will strike twice. If a move could hit multiple Pokémon but only hits one due to missing the other Pokémon, it will only strike once.

If Present heals the target it will only strike once, but if it damages the target it will strike twice (the second strike will always damage the target). Fixed-damage moves (such as Seismic Toss and Dragon Rage) deal the full amount of damage for both strikes. The damage dealt by Psywave is generated separately for each strike, and the second strike's damage is not halved. Each strike of Super Fang halves the target's HP (effectively quartering it if HP is not changed between strikes). Counter, Mirror Coat, Metal Burst, and Bide deal the full amount of damage for both strikes. The first strike of Assurance counts as previously taking damage for the second strike, giving it increased power. Fury Cutter and Echoed Voice only consider uses of the move rather than hits, so the second strike's power is not boosted by the first strike. Grass Pledge, Fire Pledge, and Water Pledge strike twice, even when used as a combination move. Natural Gift and Spit Up strike twice. Moves that require recharging after use strike twice, but the user only needs to recharge for one turn.

One-hit knockout moves, Fling, Self-Destruct, Explosion, Final Gambit, Uproar, Rollout, and Ice Ball only strike once. (Other consecutively executed moves, such as Outrage, can strike twice.) Moves with a charging turn (such as Fly and Solar Beam) only strike once, even if the Pokémon becomes fully charged in one turn (such as with a Power Herb). Endeavor also only strikes once, even if the user or target's HP is changed after it strikes (such as by Iron Barbs or the Sitrus Berry). Confusion damage only occurs once.

Spirit Shackle and Anchor Shot only trap the target after the final strike.

I did not implement some of them, I'll set the PR as draft until I fix those

jaimefd avatar May 14 '24 01:05 jaimefd

Closing this due to inactivity. Feel free to make a new request if interest is reignited

bennybroseph avatar May 19 '24 17:05 bennybroseph