pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Implemented Dancer Ability

Open YounesM opened this issue 9 months ago • 2 comments

Adds implementation for "Dancer" ability according to : https://bulbapedia.bulbagarden.net/wiki/Dancer_(Ability).

YounesM avatar May 07 '24 09:05 YounesM

When you say basic implementation, what does that imply?

Well it's honeslty not that basic anymore. I tested all the dancing moves and it seems to work as intended in solo and double battles. There might be some weird cases that I didn't think of but I think it should cover most if not all use cases.

YounesM avatar May 13 '24 06:05 YounesM

Could we get a video of this move working in game?

Sure, in a solo battle:

https://github.com/pagefaultgames/pokerogue/assets/11600168/95aac2dc-8998-425c-b419-5ee7f8545dcd

-> Player uses self status dance move
-> Opponent copies it
-> Opponent uses damaging dance move
-> Player returns it

In double battles :

https://github.com/pagefaultgames/pokerogue/assets/11600168/d398268b-8570-4d1a-bf8f-0c4a6461730c

-> Oricorio [Opp. 1] uses Feather Dance on Cyndaquil 
-> Oricorio [Player] ability triggers and uses Feather Dance on the source of the dance (Oricorio Opp. 1)
-> Oricorio [Opp. 2] ability triggers and uses Feather Dance on the same target than Oricorio [Opp. 1] (Cyndaquil)

-> Oricorio [Opp. 2] uses Fiery Dance on Cyndaquil
-> Oricorio [Player] ability triggers and uses Fiery Dance on the source of the dance (Oricorio Opp. 2)
-> Oricorio [Opp. 1] ability triggers and uses Fiery Dance on the same target than Oricorio [Opp. 2] (Cyndaquil)

-> Oricorio [Player] uses Dragon Dance
-> Oricorio [Opp. 1] and [Opp. 2] ability triggers and copies the move on themselves

-> Cyndaquil uses Aqua Step on Oricorio [Opp. 1]
-> Oricorio [Player] ability triggers and uses Aqua Step on the same target than Cyndaquil (Oricorio Opp. 1)
-> Oricorio [Opp. 1] ability triggers and uses Aqua Step on the source of the dance (Cyndaquil)
-> Cyndaquil is KO
-> Oricorio [Opp. 2] ability triggers and uses Aqua Step on the source of the dance (Cyndaquil) but since Cyndaquil is KO the move goes on Oricorio [Player] instead

I tried to cover all the possible cases that could happen when a dance move is used and when multiples dancer are in the fight on the video.

YounesM avatar May 19 '24 16:05 YounesM