Opponent pokemon sprite disappears after using Roar

[PaulBeslin]

When an opponent pokemon (Trainer or wild) uses Roar, its sprite disappears. The pokemon is still here and behaves properly, except for the sprite. Other moves such as whirlwind do not seem to be affected. Using Roar as the player works as intended.

To reproduce, override the opponent used move to be Roar.

[happinyz]

PR for the fix: https://github.com/pagefaultgames/pokerogue/pull/625

[happinyz]

PR for the fix: #625

I suspect this is something wrong with the animation file, rather than any move application/attribute logic. When changing Roar's attributes to the exact same ones as Whirlwind's, this bug still happens. However, when I switch Roar's animation to use Whirlwind's, this bug does not appear.

I tried playing around with the animation file a bit but I'm not super familiar with how the animation framework works. I've closed my PR for now. I welcome anyone who's more familiar with the animation system to tackle this bug.

[pom-eranian]

Copy pasted from discord since the issue was brought up there.

I already tried changing or removing the anim file's parameters one by one and it still happened. The behavior I saw every single time is that no matter who used the move, player or opponent, the opponent disappeared after the anim ends and before the player team UI shows up. Then I tried extending and shortening the amount of frames, and every time the opponent would disappear after the anim was done.

However having another move do the same thing is interesting. Does anyone know if baneful bunker already did this or is it a new bug? It's new.

The only part that can be fixed through the anim file is the little blip at the end like this: https://github.com/pagefaultgames/pokerogue/pull/1660#issuecomment-2154936069

[Snailman11]

Link to Discord (New Report) https://discord.com/channels/1125469663833370665/1273010472819494912

-D-tail too now

[flx-sta]

After some debugging I noticed that only Roar and Dragon Tail seem to do a false-swap of user and target during the animation. I was fighting with Charmander vs a wild Surfskit I'm going to dump some debug messages in here to show what I mean

---

Roar

anim:  PRAS- Roar 
    User Charmander  | this.user: Surskit 
    Target Surskit  | this.target: Charmander

---

Dragon Tail

anim:  PRAS- Dragon Tail 
	User Charmander  | this.user: Surfskit 
	Target Surfskit  | this.target: Charmander 

---

Whirlwind

anim:  PRAS- Twister 
    User Surskit  | this.user: Surskit 
    Target Charmander  | this.target: Charmander

---

Scratch

anim:  PRAS- Slash 
    User Charmander  | this.user: Charmander 
    Target Surskit  | this.target: Surskit