pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Implements Merciless

Open NxKarim opened this issue 10 months ago • 3 comments

  • Implements ConditionalCritAbAttr , which given the pokemon attack condition guarantees a critical hit.
  • Merciless checks for Poisoned or Intoxicated targets.
  • Fixes BlockCritAbAttr not preventing guaranteed critical hits.

NxKarim avatar May 03 '24 23:05 NxKarim

https://github.com/pagefaultgames/pokerogue/assets/43686802/b2e1446e-7dd1-4750-a5f4-9395ea5bc3ae

NxKarim avatar May 14 '24 22:05 NxKarim

Going off of the point made above, you could even do a conditional crit attr, similar to how we use our MovePowerBoostAttr. It would be super clean, and allow any "crit if x" stuff to work the same way. Like this;

new Ability(Abilities.MERCILESS, 7)
      .attr(ConditionalCritAbAttr, (user, target, move) => target.status?.effect === StatusEffect.POISON || target.status?.effect === StatusEffect.TOXIC,),
      ```

shayebeadling avatar May 15 '24 15:05 shayebeadling

Nice, I do think that's the best solution

bennybroseph avatar May 15 '24 16:05 bennybroseph